Mesa (master): i965: Remove swizzling of assignment to vector-splitting single-channel LHS.

Eric Anholt anholt at kemper.freedesktop.org
Tue Sep 28 01:46:52 UTC 2010


Module: Mesa
Branch: master
Commit: a5c6c8a31b240729baa12e2eca0ef53199efeed2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a5c6c8a31b240729baa12e2eca0ef53199efeed2

Author: Eric Anholt <eric at anholt.net>
Date:   Mon Sep 27 15:10:34 2010 -0700

i965: Remove swizzling of assignment to vector-splitting single-channel LHS.

We'd end up reading some non-x component of the float RHS.  +53 piglits.

---

 .../drivers/dri/i965/brw_fs_vector_splitting.cpp   |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp b/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp
index 9b58916..83b4af0 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp
@@ -319,8 +319,6 @@ ir_vector_splitting_visitor::visit_leave(ir_assignment *ir)
       ir->write_mask = (1 << 0);
 
       handle_rvalue(&ir->rhs);
-      ir->rhs = new(mem_ctx) ir_swizzle(ir->rhs,
-					elem, elem, elem, elem, 1);
    } else {
       handle_rvalue(&ir->rhs);
    }




More information about the mesa-commit mailing list