Mesa (master): mesa: fix a leak in _mesa_delete_texture_image()

Pekka Paalanen pq at kemper.freedesktop.org
Tue Dec 20 10:04:42 UTC 2011


Module: Mesa
Branch: master
Commit: dae2fca70521909cfdd8d217d5e42fc6b33b05f6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dae2fca70521909cfdd8d217d5e42fc6b33b05f6

Author: Pekka Paalanen <ppaalanen at gmail.com>
Date:   Fri Dec 16 16:10:47 2011 +0200

mesa: fix a leak in _mesa_delete_texture_image()

Valgrind complains about a definitely lost block allocated in
intelNewTextureImage(). This leak was apparently created by
6e0f9001fe3fb191c2928bd09aa9e9d05ddf4ea9, "mesa: move
gl_texture_image::Data, RowStride, ImageOffsets to swrast", as it
removes the free() from _mesa_delete_texture_image().

Put the free() back, fixes a Valgrind error.

Signed-off-by: Pekka Paalanen <ppaalanen at gmail.com>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/main/teximage.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 841240c..18a7b87 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -604,6 +604,7 @@ _mesa_delete_texture_image(struct gl_context *ctx,
     */
    ASSERT(ctx->Driver.FreeTextureImageBuffer);
    ctx->Driver.FreeTextureImageBuffer( ctx, texImage );
+   free(texImage);
 }
 
 




More information about the mesa-commit mailing list