Mesa (master): mesa: Remove unnecessary FLUSH_VERTICES in bind_buffer_range

Paul Berry stereotype441 at kemper.freedesktop.org
Tue Dec 20 23:41:22 UTC 2011


Module: Mesa
Branch: master
Commit: 291ae4e6396872679fef72ed4fdd46fb7f945c3d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=291ae4e6396872679fef72ed4fdd46fb7f945c3d

Author: Paul Berry <stereotype441 at gmail.com>
Date:   Fri Dec 16 13:55:37 2011 -0800

mesa: Remove unnecessary FLUSH_VERTICES in bind_buffer_range

It isn't necessary to call FLUSH_VERTICES from bind_buffer_range,
because transform feedback buffers are not allowed to be changed when
transform feedback is active.

Thanks to Marek Olšák for pointing out this bug.

Reviewed-by: Marek Olšák <maraeo at gmail.com>

---

 src/mesa/main/transformfeedback.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c
index b0b75ea..53c09e2 100644
--- a/src/mesa/main/transformfeedback.c
+++ b/src/mesa/main/transformfeedback.c
@@ -404,7 +404,11 @@ bind_buffer_range(struct gl_context *ctx, GLuint index,
 {
    struct gl_transform_feedback_object *obj =
       ctx->TransformFeedback.CurrentObject;
-   FLUSH_VERTICES(ctx, _NEW_TRANSFORM_FEEDBACK);
+
+   /* Note: no need to FLUSH_VERTICES or flag _NEW_TRANSFORM_FEEDBACK, because
+    * transform feedback buffers can't be changed while transform feedback is
+    * active.
+    */
 
    /* The general binding point */
    _mesa_reference_buffer_object(ctx,




More information about the mesa-commit mailing list