Mesa (master): i965: Drop strict conformance fallback for GL_LINE_STIPPLE.

Eric Anholt anholt at kemper.freedesktop.org
Sun Jun 5 18:24:28 UTC 2011


Module: Mesa
Branch: master
Commit: e9868979c5373501234392a38a786d5a92dc47b5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e9868979c5373501234392a38a786d5a92dc47b5

Author: Eric Anholt <eric at anholt.net>
Date:   Wed May 25 12:58:21 2011 -0700

i965: Drop strict conformance fallback for GL_LINE_STIPPLE.

We implement line stipples, just not *quite* correctly.  We have a
piglit testcase to use when we want to fix it, if we do.  Until then,
don't lie to our test suites.

---

 src/mesa/drivers/dri/i965/brw_draw.c |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index b2e89ba..103c774 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -283,24 +283,6 @@ static GLboolean check_fallbacks( struct brw_context *brw,
    if (brw->intel.conformance_mode == 0)
       return GL_FALSE;
 
-   /* Stipple -- these fallbacks could be resolved with a little
-    * bit of work?
-    */
-   if (ctx->Line.StippleFlag) {
-      for (i = 0; i < nr_prims; i++) {
-	 /* GS doesn't get enough information to know when to reset
-	  * the stipple counter?!?
-	  */
-	 if (prim[i].mode == GL_LINE_LOOP || prim[i].mode == GL_LINE_STRIP) 
-	    return GL_TRUE;
-	    
-	 if (prim[i].mode == GL_POLYGON &&
-	     (ctx->Polygon.FrontMode == GL_LINE ||
-	      ctx->Polygon.BackMode == GL_LINE))
-	    return GL_TRUE;
-      }
-   }
-
    if (ctx->Point.SmoothFlag) {
       for (i = 0; i < nr_prims; i++)
 	 if (prim[i].mode == GL_POINTS) 




More information about the mesa-commit mailing list