Mesa (master): r600g: remove useless call to u_upload_flush

Alex Deucher agd5f at kemper.freedesktop.org
Mon Jun 13 08:28:25 PDT 2011


Module: Mesa
Branch: master
Commit: 92563476e451a7df131822a8bcdedc2c161ed75f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=92563476e451a7df131822a8bcdedc2c161ed75f

Author: Pierre-Eric Pelloux-Prayer <pelloux at gmail.com>
Date:   Fri Jun 10 15:45:01 2011 +0200

r600g: remove useless call to u_upload_flush

No regressions found with :
- piglit (quick.tests)
- Unigine Heaven
- Lightsmark
- openarena
- Imprudence (Second Life fork)

agd5f Note: this patch was previously reverted due to piglit
regressions, but I'm not able to reproduce them here.
See this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=34008
and discussion:
http://lists.freedesktop.org/archives/dri-devel/2011-June/011996.html

Signed-off-by: Alex Deucher <alexdeucher at gmail.com>

---

 src/gallium/drivers/r600/r600_pipe.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
index f924d79..ce2db88 100644
--- a/src/gallium/drivers/r600/r600_pipe.c
+++ b/src/gallium/drivers/r600/r600_pipe.c
@@ -138,11 +138,6 @@ static void r600_flush(struct pipe_context *ctx,
 	dc++;
 #endif
 	r600_context_flush(&rctx->ctx);
-
-	/* XXX This shouldn't be really necessary, but removing it breaks some tests.
-	 * Needless buffer reallocations may significantly increase memory consumption,
-	 * so getting rid of this call is important. */
-	u_upload_flush(rctx->vbuf_mgr->uploader);
 }
 
 static void r600_update_num_contexts(struct r600_screen *rscreen, int diff)



More information about the mesa-commit mailing list