Mesa (master): i965/gen6: Fix scissors using invalid STATE_BASE_ADDRESS.

Eric Anholt anholt at kemper.freedesktop.org
Tue Jun 28 17:17:46 UTC 2011


Module: Mesa
Branch: master
Commit: cd7bfd5d44f543246faa7ad6ff2f8309189be963
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd7bfd5d44f543246faa7ad6ff2f8309189be963

Author: Eric Anholt <eric at anholt.net>
Date:   Sun Jun 19 11:33:40 2011 -0700

i965/gen6: Fix scissors using invalid STATE_BASE_ADDRESS.

The scissor state was incorrectly in a .prepare function instead of
.emit, so the packet would end up in the batch before the
STATE_BASE_ADDRESS.  It appears that this doesn't actually hurt, as
the scissor address gets dereferenced according to the current SBA at
draw time.

---

 src/mesa/drivers/dri/i965/gen6_scissor_state.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen6_scissor_state.c b/src/mesa/drivers/dri/i965/gen6_scissor_state.c
index fad3ca0..7492e50 100644
--- a/src/mesa/drivers/dri/i965/gen6_scissor_state.c
+++ b/src/mesa/drivers/dri/i965/gen6_scissor_state.c
@@ -31,7 +31,7 @@
 #include "intel_batchbuffer.h"
 
 static void
-gen6_prepare_scissor_state(struct brw_context *brw)
+gen6_upload_scissor_state(struct brw_context *brw)
 {
    struct intel_context *intel = &brw->intel;
    struct gl_context *ctx = &intel->ctx;
@@ -89,5 +89,5 @@ const struct brw_tracked_state gen6_scissor_state = {
       .brw = BRW_NEW_BATCH,
       .cache = 0,
    },
-   .prepare = gen6_prepare_scissor_state,
+   .emit = gen6_upload_scissor_state,
 };




More information about the mesa-commit mailing list