Mesa (master): mesa: fix the low limit of width and height for glRenderbufferStorage

Yuanhan Liu yliu at kemper.freedesktop.org
Thu Nov 3 02:27:32 UTC 2011


Module: Mesa
Branch: master
Commit: 49f8447acc430944504c658c2d2b4a2ccb3af0bc
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=49f8447acc430944504c658c2d2b4a2ccb3af0bc

Author: Yuanhan Liu <yuanhan.liu at linux.intel.com>
Date:   Tue Oct 25 15:36:59 2011 +0800

mesa: fix the low limit of width and height for glRenderbufferStorage

glRenderbufferStorage man page says:

  GL_INVALID_VALUE is generated if either of width or height is negative,
  or greater than the value of GL_MAX_RENDERBUFFER_SIZE.

NOTE: this is a candidate for the 7.11 branch

Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/main/fbobject.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index c56062a..ff46570 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -1370,12 +1370,12 @@ renderbuffer_storage(GLenum target, GLenum internalFormat,
       return;
    }
 
-   if (width < 1 || width > (GLsizei) ctx->Const.MaxRenderbufferSize) {
+   if (width < 0 || width > (GLsizei) ctx->Const.MaxRenderbufferSize) {
       _mesa_error(ctx, GL_INVALID_VALUE, "%s(width)", func);
       return;
    }
 
-   if (height < 1 || height > (GLsizei) ctx->Const.MaxRenderbufferSize) {
+   if (height < 0 || height > (GLsizei) ctx->Const.MaxRenderbufferSize) {
       _mesa_error(ctx, GL_INVALID_VALUE, "%s(height)", func);
       return;
    }




More information about the mesa-commit mailing list