Mesa (master): swrast: Skip _swrast_validate_derived in _swrast_ReadPixels( ).

Eric Anholt anholt at kemper.freedesktop.org
Fri Nov 4 06:48:37 UTC 2011


Module: Mesa
Branch: master
Commit: 3e51ef099034f8c0da4a782dfd0d92194e068d85
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e51ef099034f8c0da4a782dfd0d92194e068d85

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Oct 12 16:55:23 2011 -0700

swrast: Skip _swrast_validate_derived in _swrast_ReadPixels().

None of the callgraph below this uses derived state (almost nothing
even dereferences the swrast context).

Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/swrast/s_readpix.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/mesa/swrast/s_readpix.c b/src/mesa/swrast/s_readpix.c
index aabb1f3..b258599 100644
--- a/src/mesa/swrast/s_readpix.c
+++ b/src/mesa/swrast/s_readpix.c
@@ -608,7 +608,6 @@ _swrast_ReadPixels( struct gl_context *ctx,
 		    const struct gl_pixelstore_attrib *packing,
 		    GLvoid *pixels )
 {
-   SWcontext *swrast = SWRAST_CONTEXT(ctx);
    struct gl_pixelstore_attrib clippedPacking = *packing;
 
    if (ctx->NewState)
@@ -620,9 +619,6 @@ _swrast_ReadPixels( struct gl_context *ctx,
     */
    swrast_render_start(ctx);
 
-   if (swrast->NewState)
-      _swrast_validate_derived( ctx );
-
    /* Do all needed clipping here, so that we can forget about it later */
    if (_mesa_clip_readpixels(ctx, &x, &y, &width, &height, &clippedPacking)) {
 




More information about the mesa-commit mailing list