Mesa (master): intel: Remove duplicate test for texture attachment completeness.

Eric Anholt anholt at kemper.freedesktop.org
Tue Nov 22 22:09:46 UTC 2011


Module: Mesa
Branch: master
Commit: 05ab8fc13461aa9d6612d75c899dac20de067da6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=05ab8fc13461aa9d6612d75c899dac20de067da6

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Nov 15 12:49:25 2011 -0800

intel: Remove duplicate test for texture attachment completeness.

We are already testing this if appropriate in
intel_validate_framebuffer (FBO completeness), so no need to avoid
attaching the texture to the renderbuffer here.

This causes MESA_FORMAT_R11_G11_B10_FLOAT to now be renderable as a texture
attachment on i965.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/intel/intel_fbo.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c
index 348b927..9005402 100644
--- a/src/mesa/drivers/dri/intel/intel_fbo.c
+++ b/src/mesa/drivers/dri/intel/intel_fbo.c
@@ -981,14 +981,6 @@ intel_renderbuffer_update_wrapper(struct intel_context *intel,
    struct gl_renderbuffer *rb = &irb->Base;
 
    rb->Format = format;
-   if (!intel_span_supports_format(rb->Format)) {
-      DBG("Render to texture BAD FORMAT %s\n",
-	  _mesa_get_format_name(rb->Format));
-      return false;
-   } else {
-      DBG("Render to texture %s\n", _mesa_get_format_name(rb->Format));
-   }
-
    rb->InternalFormat = internal_format;
    rb->DataType = intel_mesa_format_to_rb_datatype(rb->Format);
    rb->_BaseFormat = _mesa_get_format_base_format(rb->Format);




More information about the mesa-commit mailing list