Mesa (master): swrast: Use GL_STENCIL_INDEX for address calculations

Ian Romanick idr at kemper.freedesktop.org
Tue Sep 6 19:10:33 UTC 2011


Module: Mesa
Branch: master
Commit: d7cb905a5a6e3ad7af1518d8e74620de729a2477
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7cb905a5a6e3ad7af1518d8e74620de729a2477

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Mon Aug 29 14:06:00 2011 -0700

swrast: Use GL_STENCIL_INDEX for address calculations

GL_COLOR_INDEX produced the same result (because GL_BITMAP is always
used for stencil glDrawPixels), but it was confusing to read.  I spent
about 15 minutes wondering, "WTF?"

Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/swrast/s_drawpix.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/swrast/s_drawpix.c b/src/mesa/swrast/s_drawpix.c
index 11c6345..63bfa79 100644
--- a/src/mesa/swrast/s_drawpix.c
+++ b/src/mesa/swrast/s_drawpix.c
@@ -335,7 +335,7 @@ draw_stencil_pixels( struct gl_context *ctx, GLint x, GLint y,
                          ? GL_UNSIGNED_BYTE : GL_UNSIGNED_SHORT;
          const GLvoid *source = _mesa_image_address2d(unpack, pixels,
                                                       width, height,
-                                                      GL_COLOR_INDEX, type,
+                                                      GL_STENCIL_INDEX, type,
                                                       row, skipPixels);
          _mesa_unpack_stencil_span(ctx, spanWidth, destType, values,
                                    type, source, unpack,




More information about the mesa-commit mailing list