Mesa (master): st/mesa: Fix a potential memory leak in get_mesa_program.

Vinson Lee vlee at kemper.freedesktop.org
Tue Aug 7 05:10:31 UTC 2012


Module: Mesa
Branch: master
Commit: 7d65356d8a4d268dce4c933d7704d709e1cdacfa
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d65356d8a4d268dce4c933d7704d709e1cdacfa

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sat Aug  4 14:04:03 2012 -0700

st/mesa: Fix a potential memory leak in get_mesa_program.

Fixes resource leak defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: José Fonseca <jfonseca at vmware.com>

---

 src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index fcd69b1..66627ac 100644
--- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
@@ -4790,7 +4790,7 @@ get_mesa_program(struct gl_context *ctx,
                  struct gl_shader_program *shader_program,
                  struct gl_shader *shader)
 {
-   glsl_to_tgsi_visitor* v = new glsl_to_tgsi_visitor();
+   glsl_to_tgsi_visitor* v;
    struct gl_program *prog;
    GLenum target;
    const char *target_string;
@@ -4822,6 +4822,7 @@ get_mesa_program(struct gl_context *ctx,
    if (!prog)
       return NULL;
    prog->Parameters = _mesa_new_parameter_list();
+   v = new glsl_to_tgsi_visitor();
    v->ctx = ctx;
    v->prog = prog;
    v->shader_program = shader_program;




More information about the mesa-commit mailing list