Mesa (master): i965: Remove four and a half year old TODO comments about samplers.
Kenneth Graunke
kwg at kemper.freedesktop.org
Sun Aug 26 05:57:06 UTC 2012
Module: Mesa
Branch: master
Commit: f510dd5d60401ee44512ba7ae4ded3b32b19f12d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f510dd5d60401ee44512ba7ae4ded3b32b19f12d
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Aug 21 23:25:50 2012 -0700
i965: Remove four and a half year old TODO comments about samplers.
I can't actually understand what these mean, and they seem to
essentially say "we should simplify things", which is a nice goal but
not very specific.
Presumably things got cleaned up at some point.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
---
src/mesa/drivers/dri/i965/brw_wm_sampler_state.c | 4 ----
src/mesa/drivers/dri/i965/gen7_sampler_state.c | 4 ----
2 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
index 1c61bd0..27f0d70 100644
--- a/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
+++ b/src/mesa/drivers/dri/i965/brw_wm_sampler_state.c
@@ -328,10 +328,6 @@ static void brw_update_sampler_state(struct brw_context *brw,
}
-/* All samplers must be uploaded in a single contiguous array, which
- * complicates various things. However, this is still too confusing -
- * FIXME: simplify all the different new texture state flags.
- */
static void
brw_upload_samplers(struct brw_context *brw)
{
diff --git a/src/mesa/drivers/dri/i965/gen7_sampler_state.c b/src/mesa/drivers/dri/i965/gen7_sampler_state.c
index 0cf6229..3c8daf9 100644
--- a/src/mesa/drivers/dri/i965/gen7_sampler_state.c
+++ b/src/mesa/drivers/dri/i965/gen7_sampler_state.c
@@ -183,10 +183,6 @@ gen7_update_sampler_state(struct brw_context *brw, int unit,
}
-/* All samplers must be uploaded in a single contiguous array, which
- * complicates various things. However, this is still too confusing -
- * FIXME: simplify all the different new texture state flags.
- */
static void
gen7_upload_samplers(struct brw_context *brw)
{
More information about the mesa-commit
mailing list