Mesa (master): radeon: Fix memory leak in radeonCreateScreen2.

Vinson Lee vlee at kemper.freedesktop.org
Sat Dec 1 03:34:42 UTC 2012


Module: Mesa
Branch: master
Commit: da7029dcb498f80d1837323038617b49cc28431f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=da7029dcb498f80d1837323038617b49cc28431f

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Thu Nov 29 23:10:03 2012 -0800

radeon: Fix memory leak in radeonCreateScreen2.

Fixes a memory leak defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/drivers/dri/radeon/radeon_screen.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/radeon/radeon_screen.c b/src/mesa/drivers/dri/radeon/radeon_screen.c
index 6f4750a..2e6cf3c 100644
--- a/src/mesa/drivers/dri/radeon/radeon_screen.c
+++ b/src/mesa/drivers/dri/radeon/radeon_screen.c
@@ -510,8 +510,10 @@ radeonCreateScreen2(__DRIscreen *sPriv)
    }
 
    ret = radeon_set_screen_flags(screen, device_id);
-   if (ret == -1)
+   if (ret == -1) {
+     free(screen);
      return NULL;
+   }
 
    if (getenv("RADEON_NO_TCL"))
 	   screen->chip_flags &= ~RADEON_CHIPSET_TCL;




More information about the mesa-commit mailing list