Mesa (master): draw: add reminder comments about similar code in different files
Brian Paul
brianp at kemper.freedesktop.org
Sat Dec 8 13:58:37 UTC 2012
Module: Mesa
Branch: master
Commit: c5f544e69075001855da9f49f1c1d06191765a6c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c5f544e69075001855da9f49f1c1d06191765a6c
Author: Brian Paul <brianp at vmware.com>
Date: Fri Dec 7 12:21:08 2012 -0700
draw: add reminder comments about similar code in different files
When one function is changed, also look at the other.
Presently, there are some differences with respect to geometry
shaders and instanced drawing...
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
---
.../auxiliary/draw/draw_pt_fetch_shade_pipeline.c | 6 ++++++
.../draw/draw_pt_fetch_shade_pipeline_llvm.c | 5 +++++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c b/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
index 053ea7d..a6f5484 100644
--- a/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
+++ b/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
@@ -51,6 +51,12 @@ struct fetch_pipeline_middle_end {
unsigned opt;
};
+
+/**
+ * Prepare/validate middle part of the vertex pipeline.
+ * NOTE: if you change this function, also look at the LLVM
+ * function llvm_middle_end_prepare() for similar changes.
+ */
static void fetch_pipeline_prepare( struct draw_pt_middle_end *middle,
unsigned prim,
unsigned opt,
diff --git a/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline_llvm.c b/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline_llvm.c
index 9b8d343..2230a7e 100644
--- a/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline_llvm.c
+++ b/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline_llvm.c
@@ -57,6 +57,11 @@ struct llvm_middle_end {
};
+/**
+ * Prepare/validate middle part of the vertex pipeline.
+ * NOTE: if you change this function, also look at the non-LLVM
+ * function fetch_pipeline_prepare() for similar changes.
+ */
static void
llvm_middle_end_prepare( struct draw_pt_middle_end *middle,
unsigned in_prim,
More information about the mesa-commit
mailing list