Mesa (master): llvmpipe: don't use user constant buffers
Brian Paul
brianp at kemper.freedesktop.org
Tue Dec 11 19:53:34 UTC 2012
Module: Mesa
Branch: master
Commit: 2ee0b442528c7d0d0207504e8d315dfb5666afcd
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ee0b442528c7d0d0207504e8d315dfb5666afcd
Author: Brian Paul <brianp at vmware.com>
Date: Mon Dec 10 12:35:23 2012 -0700
llvmpipe: don't use user constant buffers
This fixes some use-after-free issues. I haven't measured any real
performance difference with a handful of Mesa demos.
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
---
src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
index 0f30447..ab5a55b 100644
--- a/src/gallium/drivers/llvmpipe/lp_screen.c
+++ b/src/gallium/drivers/llvmpipe/lp_screen.c
@@ -203,8 +203,9 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
return 0;
case PIPE_CAP_USER_VERTEX_BUFFERS:
case PIPE_CAP_USER_INDEX_BUFFERS:
- case PIPE_CAP_USER_CONSTANT_BUFFERS:
return 1;
+ case PIPE_CAP_USER_CONSTANT_BUFFERS:
+ return 0;
case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
More information about the mesa-commit
mailing list