Mesa (master): clover: Don't erase build info of devices not being built

Tom Stellard tstellar at kemper.freedesktop.org
Thu Dec 13 20:03:28 UTC 2012


Module: Mesa
Branch: master
Commit: 7f71efcf7a8eace124e71ca72c86d4c2bdc8042d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f71efcf7a8eace124e71ca72c86d4c2bdc8042d

Author: Tom Stellard <thomas.stellard at amd.com>
Date:   Mon Dec 10 16:04:04 2012 +0000

clover: Don't erase build info of devices not being built

Every call to _cl_program::build() was erasing the binaries and logs for
every device associated with the program.  This is incorrect because
it is possible to build a program for only a subset of devices and so
any device not being build should not have this information erased.

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

---

 src/gallium/state_trackers/clover/core/program.cpp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/state_trackers/clover/core/program.cpp b/src/gallium/state_trackers/clover/core/program.cpp
index 6ca8080..5fcda23 100644
--- a/src/gallium/state_trackers/clover/core/program.cpp
+++ b/src/gallium/state_trackers/clover/core/program.cpp
@@ -42,10 +42,10 @@ _cl_program::_cl_program(clover::context &ctx,
 
 void
 _cl_program::build(const std::vector<clover::device *> &devs) {
-   __binaries.clear();
-   __logs.clear();
 
    for (auto dev : devs) {
+      __binaries.erase(dev);
+      __logs.erase(dev);
       try {
          auto module = (dev->ir_format() == PIPE_SHADER_IR_TGSI ?
                         compile_program_tgsi(__source) :




More information about the mesa-commit mailing list