Mesa (master): i965: Stop making a copy of non-builtin uniforms in ParameterValues[].

Eric Anholt anholt at kemper.freedesktop.org
Fri Dec 28 19:03:49 UTC 2012


Module: Mesa
Branch: master
Commit: 12751ef2a70f2e8ce06b116d69e475dfa5dc6f38
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=12751ef2a70f2e8ce06b116d69e475dfa5dc6f38

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Nov 21 14:33:52 2012 -0800

i965: Stop making a copy of non-builtin uniforms in ParameterValues[].

We don't need them now that our set of parameter pointers points at the
GL core storage for them.  This should save memory/bandwidth/overhead in
uniform updates.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_shader.cpp |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
index 951b5f4..1e8d574 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.cpp
+++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
@@ -100,9 +100,6 @@ brw_link_shader(struct gl_context *ctx, struct gl_shader_program *shProg)
 	return false;
       prog->Parameters = _mesa_new_parameter_list();
 
-      _mesa_generate_parameters_list_for_uniforms(shProg, &shader->base,
-						  prog->Parameters);
-
       if (stage == 0) {
 	 struct gl_vertex_program *vp = (struct gl_vertex_program *) prog;
 	 vp->UsesClipDistance = shProg->Vert.UsesClipDistance;




More information about the mesa-commit mailing list