Mesa (8.0): i965: Only set Last Render Target Select on the last FB write.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Feb 28 21:11:44 UTC 2012


Module: Mesa
Branch: 8.0
Commit: 16cc79f975816c0741711560be48fc498d4b4794
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=16cc79f975816c0741711560be48fc498d4b4794

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sat Feb 18 21:29:29 2012 -0800

i965: Only set Last Render Target Select on the last FB write.

Fixes GPU hangs in OilRush, Trine, and Amnesia: The Dark Descent,
which all use MRT (multiple render targets).

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38720
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40059
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45216
Reviewed-by: Eric Anholt <eric at anholt.net>
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 172bb92db1a3c317867d9cfec6f15c09c37a0f6c)

---

 src/mesa/drivers/dri/i965/brw_eu_emit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 3347157..b2581da 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
@@ -2188,7 +2188,7 @@ void brw_fb_WRITE(struct brw_compile *p,
 			    msg_type,
 			    msg_length,
 			    header_present,
-			    1, /* last render target write */
+			    eot, /* last render target write */
 			    response_length,
 			    eot,
 			    0 /* send_commit_msg */);




More information about the mesa-commit mailing list