Mesa (master): mesa: Do not invalidate shine tables in compute light positions.

Mathias Fröhlich frohlich at kemper.freedesktop.org
Wed Feb 29 19:42:12 UTC 2012


Module: Mesa
Branch: master
Commit: 8e5bc6dd1dab61858ae34ed76c7b2cc3e90b7ad5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e5bc6dd1dab61858ae34ed76c7b2cc3e90b7ad5

Author: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
Date:   Wed Feb 29 18:19:34 2012 +0100

mesa: Do not invalidate shine tables in compute light positions.

Since the shine tables are now only used in the tnl lighting stage, where
they are validated through the tnl driver function NotifyMaterialChange
called in tnl/t_vb_light.c, we can not omit calling
_mesa_validate_all_lighting_tables (which only validates the shine tables)
in main/light.c.

Reviewed-by: Alex Deucher <alexdeucher at gmail.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
Signed-off-by: Mathias Froehlich <Mathias.Froehlich at web.de>

---

 src/mesa/main/light.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c
index a120b12..f40e561 100644
--- a/src/mesa/main/light.c
+++ b/src/mesa/main/light.c
@@ -1052,9 +1052,6 @@ compute_light_positions( struct gl_context *ctx )
       TRANSFORM_NORMAL( ctx->_EyeZDir, eye_z, ctx->ModelviewMatrixStack.Top->m );
    }
 
-   /* Make sure all the light tables are updated before the computation */
-   _mesa_validate_all_lighting_tables(ctx);
-
    foreach (light, &ctx->Light.EnabledList) {
 
       if (ctx->_NeedEyeCoords) {




More information about the mesa-commit mailing list