Mesa (master): intel: Fix bad read/ write flags on self-copies for glCopyBufferSubData().

Eric Anholt anholt at kemper.freedesktop.org
Wed Jan 4 18:00:00 UTC 2012


Module: Mesa
Branch: master
Commit: 15e309cf84444a8f9ce7f7c86f0a0f391721bc50
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=15e309cf84444a8f9ce7f7c86f0a0f391721bc50

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Dec 27 16:42:44 2011 -0800

intel: Fix bad read/write flags on self-copies for glCopyBufferSubData().

We didn't consume these flags in any way that would produce a
functional difference, but we might have some day.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/intel/intel_buffer_objects.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_buffer_objects.c b/src/mesa/drivers/dri/intel/intel_buffer_objects.c
index 4a1a816..9b1f642 100644
--- a/src/mesa/drivers/dri/intel/intel_buffer_objects.c
+++ b/src/mesa/drivers/dri/intel/intel_buffer_objects.c
@@ -663,7 +663,9 @@ intel_bufferobj_copy_subdata(struct gl_context *ctx,
        */
       if (src == dst) {
 	 char *ptr = intel_bufferobj_map_range(ctx, 0, dst->Size,
-					       GL_MAP_READ_BIT, dst);
+					       GL_MAP_READ_BIT |
+					       GL_MAP_WRITE_BIT,
+					       dst);
 	 memmove(ptr + write_offset, ptr + read_offset, size);
 	 intel_bufferobj_unmap(ctx, dst);
       } else {




More information about the mesa-commit mailing list