Mesa (master): i965: Fix zeroing of unused attributes in 3DSTATE_SBE.

Kenneth Graunke kwg at kemper.freedesktop.org
Mon Jan 9 21:47:08 UTC 2012


Module: Mesa
Branch: master
Commit: a48cc138a8b7c55f8d12796677e081c2b2085f48
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a48cc138a8b7c55f8d12796677e081c2b2085f48

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun Jan  8 16:27:36 2012 -0800

i965: Fix zeroing of unused attributes in 3DSTATE_SBE.

This brings the code in sync with gen6_sf_state.c; presumably the
mistake was a botched rebase on initial Ivybridge bring-up patches.

Found by diffing batch buffer dumps and noticing the random values.
Thanks to Eric for catching the obvious mistake.

NOTE: This is a candidate for the 7.11 branch.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/gen7_sf_state.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen7_sf_state.c b/src/mesa/drivers/dri/i965/gen7_sf_state.c
index 9085318..c4cacf0 100644
--- a/src/mesa/drivers/dri/i965/gen7_sf_state.c
+++ b/src/mesa/drivers/dri/i965/gen7_sf_state.c
@@ -111,8 +111,8 @@ upload_sbe_state(struct brw_context *brw)
                            ctx->VertexProgram._TwoSideEnabled);
    }
 
-   for (; attr < FRAG_ATTRIB_MAX; attr++)
-      attr_overrides[input_index++] = 0;
+   for (; input_index < FRAG_ATTRIB_MAX; input_index++)
+      attr_overrides[input_index] = 0;
 
    BEGIN_BATCH(14);
    OUT_BATCH(_3DSTATE_SBE << 16 | (14 - 2));




More information about the mesa-commit mailing list