Mesa (master): scons: don't add -Wmissing-field-initializers

Marek Olšák mareko at kemper.freedesktop.org
Sun Jan 29 01:23:22 UTC 2012


Module: Mesa
Branch: master
Commit: 335d49ef1581c2954cfa17a5c603ca54dd770a89
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=335d49ef1581c2954cfa17a5c603ca54dd770a89

Author: Marek Olšák <maraeo at gmail.com>
Date:   Wed Jan 25 14:08:16 2012 +0100

scons: don't add -Wmissing-field-initializers

The warning is absolutely useless. It doesn't actually say that there are
uninitialized variables. It points out the fact that there are missing
initializers and that variables are initialized to zero implicitly, which is
exactly what we want and what we commonly make use of.

C90 and C99 require all unspecified variables in the initializer list to be set
to zero.

---

 scons/gallium.py |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/scons/gallium.py b/scons/gallium.py
index 86adc3e..eed89cf 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -364,10 +364,6 @@ def generate(env):
             '-Wmissing-prototypes',
             '-std=gnu99',
         ]
-        if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.0'):
-            ccflags += [
-                '-Wmissing-field-initializers',
-            ]
         if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.2'):
             ccflags += [
                 '-Wpointer-arith',




More information about the mesa-commit mailing list