Mesa (master): gallium/postprocess: document serious issue causing undefined behavior

Marek Olšák mareko at kemper.freedesktop.org
Fri Mar 30 09:18:08 PDT 2012


Module: Mesa
Branch: master
Commit: 99a192ce7d8690f44a1f23a432607b6ce5031942
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=99a192ce7d8690f44a1f23a432607b6ce5031942

Author: Marek Olšák <maraeo at gmail.com>
Date:   Thu Mar 29 21:28:55 2012 +0200

gallium/postprocess: document serious issue causing undefined behavior

---

 src/gallium/auxiliary/postprocess/pp_program.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/gallium/auxiliary/postprocess/pp_program.c b/src/gallium/auxiliary/postprocess/pp_program.c
index 5c819a9..31e2bee 100644
--- a/src/gallium/auxiliary/postprocess/pp_program.c
+++ b/src/gallium/auxiliary/postprocess/pp_program.c
@@ -53,6 +53,10 @@ pp_init_prog(struct pp_queue_t *ppq, struct pipe_screen *pscreen)
 
    p->screen = pscreen;
    p->pipe = pscreen->context_create(pscreen, NULL);
+
+   /* XXX this doesn't use the cso_context of the state tracker, but creates
+    * its own. Having 2 existing cso_contexts use 1 pipe_context may cause
+    * undefined behavior! */
    p->cso = cso_create_context(p->pipe);
 
    {



More information about the mesa-commit mailing list