Mesa (master): i965: Remove brw_set_predicate_inverse(p, true) from scratch offset code
Kenneth Graunke
kwg at kemper.freedesktop.org
Fri Sep 21 08:32:43 UTC 2012
Module: Mesa
Branch: master
Commit: cd49025affe621548ca66df8c1a2ec38829eafe3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd49025affe621548ca66df8c1a2ec38829eafe3
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Sep 20 16:31:15 2012 -0700
i965: Remove brw_set_predicate_inverse(p, true) from scratch offset code
Given that it exists between a push/pop of instruction state, this call
can only affect the MOV or ADD instruction generated just below it.
Neither of those instructions are predicated, so it makes no sense to
ask for the inverse predicate.
This fixes grumblings from the simulator debugger, which was
complaining about an invalid predicate.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
---
src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
index 6417fdb..27758ab 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp
@@ -521,7 +521,6 @@ vec4_visitor::generate_oword_dual_block_offsets(struct brw_reg m1,
brw_MOV(p, m1_0, index_0);
- brw_set_predicate_inverse(p, true);
if (index.file == BRW_IMMEDIATE_VALUE) {
index_4.dw1.ud += second_vertex_offset;
brw_MOV(p, m1_4, index_4);
More information about the mesa-commit
mailing list