Mesa (master): glsl: Initialize ast_parameter_declarator member variables.

Vinson Lee vlee at kemper.freedesktop.org
Wed Feb 6 06:16:19 UTC 2013


Module: Mesa
Branch: master
Commit: d08cee5d80f394d8391c09f8506b2ee97125dcc1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d08cee5d80f394d8391c09f8506b2ee97125dcc1

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri Feb  1 23:27:34 2013 -0800

glsl: Initialize ast_parameter_declarator member variables.

Fixes uninitialized pointer field defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/glsl/ast.h |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 1a28963..fcc6b45 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -547,11 +547,15 @@ public:
 
 class ast_parameter_declarator : public ast_node {
 public:
-   ast_parameter_declarator()
+   ast_parameter_declarator() :
+      type(NULL),
+      identifier(NULL),
+      is_array(false),
+      array_size(NULL),
+      formal_parameter(false),
+      is_void(false)
    {
-      this->identifier = NULL;
-      this->is_array = false;
-      this->array_size = 0;
+      /* empty */
    }
 
    virtual void print(void) const;




More information about the mesa-commit mailing list