Mesa (master): i965: Fix assignment instead of comparison in asserts.
Chad Versace
chadversary at kemper.freedesktop.org
Mon Jan 28 21:51:45 UTC 2013
Module: Mesa
Branch: master
Commit: 1559994cba380a4e87a5e8dbb04b0a7475711756
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1559994cba380a4e87a5e8dbb04b0a7475711756
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sat Jan 26 08:27:50 2013 +0100
i965: Fix assignment instead of comparison in asserts.
Fixes side effect in assertion defects reported by Coverity.
Note: This is a candidate for the 9.1 branch.
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
---
src/mesa/drivers/dri/i965/brw_fs_emit.cpp | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
index d9ed27c..45072da 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp
@@ -951,8 +951,8 @@ fs_generator::generate_pack_half_2x16_split(fs_inst *inst,
{
assert(intel->gen >= 7);
assert(dst.type == BRW_REGISTER_TYPE_UD);
- assert(x.type = BRW_REGISTER_TYPE_F);
- assert(y.type = BRW_REGISTER_TYPE_F);
+ assert(x.type == BRW_REGISTER_TYPE_F);
+ assert(y.type == BRW_REGISTER_TYPE_F);
/* From the Ivybridge PRM, Vol4, Part3, Section 6.27 f32to16:
*
More information about the mesa-commit
mailing list