Mesa (master): draw/llvm: index overflows if it's greater than elt max

Zack Rusin zack at kemper.freedesktop.org
Wed Jul 3 23:10:31 UTC 2013


Module: Mesa
Branch: master
Commit: 09820902d74eec1eed054388f6999cd66227b6b1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=09820902d74eec1eed054388f6999cd66227b6b1

Author: Zack Rusin <zackr at vmware.com>
Date:   Tue Jul  2 21:52:55 2013 -0400

draw/llvm: index overflows if it's greater than elt max

The comparison, incorrectly, was greater-than-or-equal to
elt max.

Signed-off-by: Zack Rusin <zackr at vmware.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>

---

 src/gallium/auxiliary/draw/draw_llvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary/draw/draw_llvm.c
index f9bcadc..79e7a9b 100644
--- a/src/gallium/auxiliary/draw/draw_llvm.c
+++ b/src/gallium/auxiliary/draw/draw_llvm.c
@@ -1671,7 +1671,7 @@ draw_llvm_generate(struct draw_llvm *llvm, struct draw_llvm_variant *variant,
                   gallivm,
                   lp_build_vec_type(gallivm, lp_type_int(32)), "");
             struct lp_build_if_state if_ctx;
-            index_overflowed = LLVMBuildICmp(builder, LLVMIntUGE,
+            index_overflowed = LLVMBuildICmp(builder, LLVMIntUGT,
                                              true_index, fetch_elt_max,
                                              "index_overflowed");
             




More information about the mesa-commit mailing list