Mesa (master): glx: Require proper drawableType in init_fbconfig_for_chooser

Ian Romanick idr at kemper.freedesktop.org
Thu Jul 18 23:03:55 UTC 2013


Module: Mesa
Branch: master
Commit: 4473af7aca97d360786954786cbbab8af1424a22
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4473af7aca97d360786954786cbbab8af1424a22

Author: Tomasz Lis <tomasz.lis at intel.com>
Date:   Wed Jul 17 13:49:20 2013 +0200

glx: Require proper drawableType in init_fbconfig_for_chooser

Make sure that init_fbconfig_for_chooser sets correct value of
drawableType for visual configs and fbconfigs.

Signed-off-by: Tomasz Lis <tomasz.lis at intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/glx/glxcmds.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c
index 7c66c9b..3b250cc 100644
--- a/src/glx/glxcmds.c
+++ b/src/glx/glxcmds.c
@@ -911,12 +911,17 @@ init_fbconfig_for_chooser(struct glx_config * config,
    config->visualID = (XID) GLX_DONT_CARE;
    config->visualType = GLX_DONT_CARE;
 
-   /* glXChooseFBConfig specifies different defaults for these two than
+   /* glXChooseFBConfig specifies different defaults for these properties than
     * glXChooseVisual.
     */
    if (fbconfig_style_tags) {
       config->rgbMode = GL_TRUE;
       config->doubleBufferMode = GLX_DONT_CARE;
+      /* allow any kind of drawable, including those for off-screen buffers */
+      config->drawableType = 0;
+   } else {
+       /* allow configs which support on-screen drawing */
+       config->drawableType = GLX_WINDOW_BIT;
    }
 
    config->visualRating = GLX_DONT_CARE;




More information about the mesa-commit mailing list