Mesa (master): util: add comment about bogus transfer flags
Roland Scheidegger
sroland at kemper.freedesktop.org
Fri Jun 7 19:15:30 UTC 2013
Module: Mesa
Branch: master
Commit: fa8cefa892bd12ae9719927ee159cf48776f68d8
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa8cefa892bd12ae9719927ee159cf48776f68d8
Author: Roland Scheidegger <sroland at vmware.com>
Date: Fri Jun 7 21:12:22 2013 +0200
util: add comment about bogus transfer flags
---
src/gallium/auxiliary/util/u_transfer.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_transfer.c b/src/gallium/auxiliary/util/u_transfer.c
index 56e059b..7804f2a 100644
--- a/src/gallium/auxiliary/util/u_transfer.c
+++ b/src/gallium/auxiliary/util/u_transfer.c
@@ -25,6 +25,7 @@ void u_default_transfer_inline_write( struct pipe_context *pipe,
usage |= PIPE_TRANSFER_WRITE;
/* transfer_inline_write implicitly discards the rewritten buffer range */
+ /* XXX this looks very broken for non-buffer resources having more than one dim. */
if (box->x == 0 && box->width == resource->width0) {
usage |= PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE;
} else {
More information about the mesa-commit
mailing list