Mesa (master): mesa: Prevent possible out-of-bounds read by save_SamplerParameteriv.

Vinson Lee vlee at kemper.freedesktop.org
Sat Jun 8 20:37:00 UTC 2013


Module: Mesa
Branch: master
Commit: ce1f85133d15098ae97a28bbcfa13c4995b772e2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce1f85133d15098ae97a28bbcfa13c4995b772e2

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Wed Jun  5 23:01:00 2013 -0700

mesa: Prevent possible out-of-bounds read by save_SamplerParameteriv.

Fixes "Out-of-bounds access" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/main/dlist.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index abc8665..8900c89 100644
--- a/src/mesa/main/dlist.c
+++ b/src/mesa/main/dlist.c
@@ -7024,7 +7024,10 @@ save_SamplerParameteriv(GLuint sampler, GLenum pname, const GLint *params)
 static void GLAPIENTRY
 save_SamplerParameteri(GLuint sampler, GLenum pname, GLint param)
 {
-   save_SamplerParameteriv(sampler, pname, &param);
+   GLint parray[4];
+   parray[0] = param;
+   parray[1] = parray[2] = parray[3] = 0;
+   save_SamplerParameteriv(sampler, pname, param);
 }
 
 static void GLAPIENTRY




More information about the mesa-commit mailing list