Mesa (master): st/mesa: fix GL_FEEDBACK mode inverted Y coordinate bug
Brian Paul
brianp at kemper.freedesktop.org
Tue Nov 19 20:23:08 UTC 2013
Module: Mesa
Branch: master
Commit: 15d8e05e1e98a9bfd5a365d0fda222668f24261f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=15d8e05e1e98a9bfd5a365d0fda222668f24261f
Author: Brian Paul <brianp at vmware.com>
Date: Tue Nov 19 13:09:57 2013 -0700
st/mesa: fix GL_FEEDBACK mode inverted Y coordinate bug
We need to check the drawbuffer's orientation before inverting Y
coordinates. Fixes piglit feedback tests when running with the
-fbo option.
Cc: "9.2" "10.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
---
src/mesa/state_tracker/st_cb_feedback.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_feedback.c b/src/mesa/state_tracker/st_cb_feedback.c
index d2e4346..34a16cc 100644
--- a/src/mesa/state_tracker/st_cb_feedback.c
+++ b/src/mesa/state_tracker/st_cb_feedback.c
@@ -85,9 +85,11 @@ feedback_vertex(struct gl_context *ctx, const struct draw_context *draw,
const GLfloat *color, *texcoord;
GLuint slot;
- /* Recall that Y=0=Top of window for Gallium wincoords */
win[0] = v->data[0][0];
- win[1] = ctx->DrawBuffer->Height - v->data[0][1];
+ if (st_fb_orientation(ctx->DrawBuffer) == Y_0_TOP)
+ win[1] = ctx->DrawBuffer->Height - v->data[0][1];
+ else
+ win[1] = v->data[0][1];
win[2] = v->data[0][2];
win[3] = 1.0F / v->data[0][3];
More information about the mesa-commit
mailing list