Mesa (master): i965: Emit a performance warning on conditional rendering.
Kenneth Graunke
kwg at kemper.freedesktop.org
Fri Aug 8 07:50:43 UTC 2014
Module: Mesa
Branch: master
Commit: ae95b9dd9be56ad84a8a4ab5955f580c337259cb
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae95b9dd9be56ad84a8a4ab5955f580c337259cb
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Sun Aug 3 23:54:22 2014 -0700
i965: Emit a performance warning on conditional rendering.
We have a CPU-side implementation of conditional rendering; it really
should be done on the GPU. It's not necessarily that hard, but nobody
has gotten to fixing it yet.
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
---
src/mesa/drivers/dri/i965/brw_draw.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index 4dae7d3..412c360 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -539,6 +539,11 @@ void brw_draw_prims( struct gl_context *ctx,
assert(unused_tfb_object == NULL);
+ if (ctx->Query.CondRenderQuery) {
+ perf_debug("Conditional rendering is implemented in software and may "
+ "stall. This should be fixed in the driver.\n");
+ }
+
if (!_mesa_check_conditional_render(ctx))
return;
More information about the mesa-commit
mailing list