Mesa (master): vc4: Drop incorrect attempt to incorrectly invert the primconvert hw_mask.

Eric Anholt anholt at kemper.freedesktop.org
Fri Aug 15 19:04:13 UTC 2014


Module: Mesa
Branch: master
Commit: f663102585f9654200e531b42d5e8831ba7ed77f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f663102585f9654200e531b42d5e8831ba7ed77f

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Aug 13 10:43:26 2014 -0700

vc4: Drop incorrect attempt to incorrectly invert the primconvert hw_mask.

The hw_mask is the set of primitives you actually support, so this attempt
to provide the set of formats that's unsupported was wrong in two ways (it
was intended to be '~' not '!').  However, we only call this code when
prim isn't one of the actually supported hw_mask bits, so missing out on
the memcpy didn't matter anyway.

---

 src/gallium/drivers/vc4/vc4_context.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/vc4/vc4_context.c b/src/gallium/drivers/vc4/vc4_context.c
index 2fc571a..1ffaab1 100644
--- a/src/gallium/drivers/vc4/vc4_context.c
+++ b/src/gallium/drivers/vc4/vc4_context.c
@@ -303,7 +303,7 @@ vc4_context_create(struct pipe_screen *pscreen, void *priv)
                 goto fail;
 
         vc4->primconvert = util_primconvert_create(pctx,
-                                                   !((1 << PIPE_PRIM_QUADS) - 1));
+                                                   (1 << PIPE_PRIM_QUADS) - 1);
         if (!vc4->primconvert)
                 goto fail;
 




More information about the mesa-commit mailing list