Mesa (master): util: Unbreak usage of assert()/debug_assert() inside expressions.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Fri Dec 12 14:20:05 UTC 2014


Module: Mesa
Branch: master
Commit: e75e677d288e67c3c05e7b8744e08cd73bdcbed8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e75e677d288e67c3c05e7b8744e08cd73bdcbed8

Author: José Fonseca <jfonseca at vmware.com>
Date:   Fri Dec 12 14:06:17 2014 +0000

util: Unbreak usage of assert()/debug_assert() inside expressions.

f0ba7d897d1c22202531acb70f134f2edc30557d made debug_assert()/assert()
unsafe for expressions, but only now that u_atomic.h started to rely on
them for Windows that this became an issue.

This fixes non-debug builds with MSVC.
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/gallium/auxiliary/util/u_debug.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h
index badd5e2..4c22fdf 100644
--- a/src/gallium/auxiliary/util/u_debug.h
+++ b/src/gallium/auxiliary/util/u_debug.h
@@ -185,7 +185,7 @@ void _debug_assert_fail(const char *expr,
 #ifdef DEBUG
 #define debug_assert(expr) ((expr) ? (void)0 : _debug_assert_fail(#expr, __FILE__, __LINE__, __FUNCTION__))
 #else
-#define debug_assert(expr) do { } while (0 && (expr))
+#define debug_assert(expr) (void)(0 && (expr))
 #endif
 
 




More information about the mesa-commit mailing list