Mesa (master): i965/fs: Drop dead comment about the old proj_attrib_mask optimization.

Eric Anholt anholt at kemper.freedesktop.org
Tue Feb 18 18:37:22 UTC 2014


Module: Mesa
Branch: master
Commit: 422679835479a053d5b5ac9cf75e2fbb7e827755
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=422679835479a053d5b5ac9cf75e2fbb7e827755

Author: Eric Anholt <eric at anholt.net>
Date:   Fri Feb 14 15:41:40 2014 -0800

i965/fs: Drop dead comment about the old proj_attrib_mask optimization.

The code was removed early last year.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_fs.cpp |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 4f5558b..d35928e 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -1108,12 +1108,6 @@ fs_visitor::emit_general_interpolation(ir_variable *ir)
 	 } else {
 	    /* Smooth/noperspective interpolation case. */
 	    for (unsigned int k = 0; k < type->vector_elements; k++) {
-	       /* FINISHME: At some point we probably want to push
-		* this farther by giving similar treatment to the
-		* other potentially constant components of the
-		* attribute, as well as making brw_vs_constval.c
-		* handle varyings other than gl_TexCoord.
-		*/
                struct brw_reg interp = interp_reg(location, k);
                emit_linterp(attr, fs_reg(interp), interpolation_mode,
                             ir->data.centroid && !c->key.persample_shading,




More information about the mesa-commit mailing list