Mesa (master): i965/fs: Move setting opcode = NOP to its one useful location.

Matt Turner mattst88 at kemper.freedesktop.org
Sat Feb 22 06:50:00 UTC 2014


Module: Mesa
Branch: master
Commit: 070f20272fcfdcafe5d843d240e876ef5cfda560
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=070f20272fcfdcafe5d843d240e876ef5cfda560

Author: Matt Turner <mattst88 at gmail.com>
Date:   Thu Feb 20 08:19:19 2014 -0800

i965/fs: Move setting opcode = NOP to its one useful location.

All other callers of init() immediately set opcode to something else.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_fs.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 2ffeffa..dfb59aa 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -55,7 +55,6 @@ void
 fs_inst::init()
 {
    memset(this, 0, sizeof(*this));
-   this->opcode = BRW_OPCODE_NOP;
    this->conditional_mod = BRW_CONDITIONAL_NONE;
 
    this->dst = reg_undef;
@@ -70,6 +69,7 @@ fs_inst::init()
 fs_inst::fs_inst()
 {
    init();
+   this->opcode = BRW_OPCODE_NOP;
 }
 
 fs_inst::fs_inst(enum opcode opcode)




More information about the mesa-commit mailing list