Mesa (master): mesa/main: Free ctx->DrawIndirectBuffer during teardown
Aaron Watry
awatry at kemper.freedesktop.org
Thu Jan 16 16:10:23 UTC 2014
Module: Mesa
Branch: master
Commit: 188383591d6d657b557a5407ee9b7b993f79c53b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=188383591d6d657b557a5407ee9b7b993f79c53b
Author: Aaron Watry <awatry at gmail.com>
Date: Thu Jan 2 11:18:09 2014 -0600
mesa/main: Free ctx->DrawIndirectBuffer during teardown
ctx->DrawIndirectBuffer wasn't being free'd in _mesa_free_buffer_objects
With this patch, "valgrind --leak-check=full glxgears" on evergreen (CEDAR)
now shows:
LEAK SUMMARY:
definitely lost: 0 bytes in 0 blocks
indirectly lost: 0 bytes in 0 blocks
possibly lost: 0 bytes in 0 blocks
still reachable: 70,228 bytes in 651 blocks
suppressed: 0 bytes in 0 blocks
Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
---
src/mesa/main/bufferobj.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index a3d8f24..9336759 100644
--- a/src/mesa/main/bufferobj.c
+++ b/src/mesa/main/bufferobj.c
@@ -871,6 +871,8 @@ _mesa_free_buffer_objects( struct gl_context *ctx )
_mesa_reference_buffer_object(ctx, &ctx->UniformBuffer, NULL);
+ _mesa_reference_buffer_object(ctx, &ctx->DrawIndirectBuffer, NULL);
+
for (i = 0; i < MAX_COMBINED_UNIFORM_BUFFERS; i++) {
_mesa_reference_buffer_object(ctx,
&ctx->UniformBufferBindings[i].BufferObject,
More information about the mesa-commit
mailing list