Mesa (master): i965/fs: Fix the example about overwriting uniforms in SIMD16.
Matt Turner
mattst88 at kemper.freedesktop.org
Tue Jan 21 22:26:43 UTC 2014
Module: Mesa
Branch: master
Commit: 80b949f16b3461c65273bb5d0e263dfffaab400e
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=80b949f16b3461c65273bb5d0e263dfffaab400e
Author: Matt Turner <mattst88 at gmail.com>
Date: Sat Dec 7 12:59:59 2013 -0800
i965/fs: Fix the example about overwriting uniforms in SIMD16.
mov takes only a single source argument. Example instruction
inexplicably changed from add to mov in commit f10f5e49.
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
---
src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp b/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp
index fa84c55..a29767d 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp
@@ -64,18 +64,18 @@ fs_live_variables::setup_one_read(bblock_t *block, fs_inst *inst,
* destination starts (naturally). This gets more complicated for
* simd16, because the instruction:
*
- * mov(16) g4<1>F g4<8,8,1>F g6<8,8,1>F
+ * add(16) g4<1>F g4<8,8,1>F g6<8,8,1>F
*
* is actually decoded in hardware as:
*
- * mov(8) g4<1>F g4<8,8,1>F g6<8,8,1>F
- * mov(8) g5<1>F g5<8,8,1>F g7<8,8,1>F
+ * add(8) g4<1>F g4<8,8,1>F g6<8,8,1>F
+ * add(8) g5<1>F g5<8,8,1>F g7<8,8,1>F
*
* Which is safe. However, if we have uniform accesses
* happening, we get into trouble:
*
- * mov(8) g4<1>F g4<0,1,0>F g6<8,8,1>F
- * mov(8) g5<1>F g4<0,1,0>F g7<8,8,1>F
+ * add(8) g4<1>F g4<0,1,0>F g6<8,8,1>F
+ * add(8) g5<1>F g4<0,1,0>F g7<8,8,1>F
*
* Now our destination for the first instruction overwrote the
* second instruction's src0, and we get garbage for those 8
More information about the mesa-commit
mailing list