Mesa (master): st/mesa: fix glReadBuffer(GL_NONE) segfault

Brian Paul brianp at kemper.freedesktop.org
Thu Jan 23 18:17:08 UTC 2014


Module: Mesa
Branch: master
Commit: f7c118ffbfdafaccd4ec05d4a040d07e120c5090
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7c118ffbfdafaccd4ec05d4a040d07e120c5090

Author: Brian Paul <brianp at vmware.com>
Date:   Thu Jan 23 09:47:34 2014 -0700

st/mesa: fix glReadBuffer(GL_NONE) segfault

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73956
Cc: 10.0 <mesa-stable at lists.freedesktop.org>
Tested-by: Ahmed Allam <ahmabdabd at hotmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/mesa/state_tracker/st_cb_fbo.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c
index 637f7ee..eca04b8 100644
--- a/src/mesa/state_tracker/st_cb_fbo.c
+++ b/src/mesa/state_tracker/st_cb_fbo.c
@@ -700,7 +700,8 @@ st_ReadBuffer(struct gl_context *ctx, GLenum buffer)
    (void) buffer;
 
    /* add the renderbuffer on demand */
-   st_manager_add_color_renderbuffer(st, fb, fb->_ColorReadBufferIndex);
+   if (fb->_ColorReadBufferIndex >= 0)
+      st_manager_add_color_renderbuffer(st, fb, fb->_ColorReadBufferIndex);
 }
 
 




More information about the mesa-commit mailing list