Mesa (master): st/mesa: add a simple sanity check assertion in st_validate_attachment()

Brian Paul brianp at kemper.freedesktop.org
Fri Jan 24 20:35:35 UTC 2014


Module: Mesa
Branch: master
Commit: e2dd240e326f5af2ad44d78bc245dfcc5c35616d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e2dd240e326f5af2ad44d78bc245dfcc5c35616d

Author: Brian Paul <brianp at vmware.com>
Date:   Thu Jan 23 18:18:17 2014 -0700

st/mesa: add a simple sanity check assertion in st_validate_attachment()

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/mesa/state_tracker/st_cb_fbo.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c
index eca04b8..7801484 100644
--- a/src/mesa/state_tracker/st_cb_fbo.c
+++ b/src/mesa/state_tracker/st_cb_fbo.c
@@ -544,6 +544,12 @@ st_validate_attachment(struct gl_context *ctx,
    gl_format texFormat;
    GLboolean valid;
 
+   /* Sanity check: we must be binding the surface as a (color) render target
+    * or depth/stencil target.
+    */
+   assert(bindings == PIPE_BIND_RENDER_TARGET ||
+          bindings == PIPE_BIND_DEPTH_STENCIL);
+
    /* Only validate texture attachments for now, since
     * st_renderbuffer_alloc_storage makes sure that
     * the format is supported.




More information about the mesa-commit mailing list