Mesa (master): i965: Fix stale comments about the state cache.
Kenneth Graunke
kwg at kemper.freedesktop.org
Wed Jul 2 19:46:29 UTC 2014
Module: Mesa
Branch: master
Commit: a6af5602afc595b57672ae9a2020dcd4ef1319ff
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a6af5602afc595b57672ae9a2020dcd4ef1319ff
Author: Eric Anholt <eric at anholt.net>
Date: Sun May 18 20:48:16 2014 -0700
i965: Fix stale comments about the state cache.
This changed in the state streaming work years ago.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/mesa/drivers/dri/i965/brw_cc.c | 2 +-
src/mesa/drivers/dri/i965/brw_context.h | 9 ++++++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_cc.c b/src/mesa/drivers/dri/i965/brw_cc.c
index 2f4062b..289f65b 100644
--- a/src/mesa/drivers/dri/i965/brw_cc.c
+++ b/src/mesa/drivers/dri/i965/brw_cc.c
@@ -97,7 +97,7 @@ brw_fix_xRGB_alpha(GLenum function)
}
/**
- * Creates the state cache entry for the given CC unit key.
+ * Creates a CC unit packet from the current blend state.
*/
static void upload_cc_unit(struct brw_context *brw)
{
diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
index bc272c5..f13d99c 100644
--- a/src/mesa/drivers/dri/i965/brw_context.h
+++ b/src/mesa/drivers/dri/i965/brw_context.h
@@ -230,7 +230,14 @@ struct brw_state_flags {
* State update flags signalled as the result of brw_tracked_state updates
*/
GLuint brw;
- /** State update flags signalled by brw_state_cache.c searches */
+ /**
+ * State update flags that used to be signalled by brw_state_cache.c
+ * searches.
+ *
+ * Now almost all of that state is just streamed out on demand, but the
+ * flags for those state blobs updating have stayed in the same bitfield.
+ * brw_state_cache.c still flags CACHE_NEW_*_PROG.
+ */
GLuint cache;
};
More information about the mesa-commit
mailing list