Mesa (master): i915: Fix up intelInitScreen2 for DRI3

Kenneth Graunke kwg at kemper.freedesktop.org
Thu Jul 17 21:40:46 UTC 2014


Module: Mesa
Branch: master
Commit: b656e3c603da46fe0acd9905dc039c93d76f0b06
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b656e3c603da46fe0acd9905dc039c93d76f0b06

Author: Adel Gadllah <adel.gadllah at gmail.com>
Date:   Thu Jul  3 22:13:53 2014 +0200

i915: Fix up intelInitScreen2 for DRI3

Commit 442442026eb updated both i915 and i965 for DRI3 support,
but one check in intelInitScreen2 was missed for i915 causing crashes
when trying to use i915 with DRI3.

So fix that up.

Reported-by: Igor Gnatenko <i.gnatenko.brain at gmail.com>
References: https://bugzilla.redhat.com/show_bug.cgi?id=1115323
References: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754297
Tested-by: František Zatloukal <Zatloukal.Frantisek at gmail.com>
Tested-by: Dirk Griesbach <spamthis at freenet.de>
Signed-off-by: Adel Gadllah <adel.gadllah at gmail.com>
Acked-by: Kenneth Graunke <kenneth at whitecape.org>
Cc: "10.2" <mesa-stable at lists.freedesktop.org>

---

 src/mesa/drivers/dri/i915/intel_screen.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/src/mesa/drivers/dri/i915/intel_screen.c
index 9b4e490..4c9726c 100644
--- a/src/mesa/drivers/dri/i915/intel_screen.c
+++ b/src/mesa/drivers/dri/i915/intel_screen.c
@@ -1152,7 +1152,8 @@ __DRIconfig **intelInitScreen2(__DRIscreen *psp)
 {
    struct intel_screen *intelScreen;
 
-   if (psp->dri2.loader->base.version <= 2 ||
+   if (psp->image.loader) {
+   } else if (psp->dri2.loader->base.version <= 2 ||
        psp->dri2.loader->getBuffersWithFormat == NULL) {
       fprintf(stderr,
 	      "\nERROR!  DRI2 loader with getBuffersWithFormat() "




More information about the mesa-commit mailing list