Mesa (master): main/format_pack: Fix a wrong datatype in pack_ubyte_R8G8_UNORM

Jason Ekstrand jekstrand at kemper.freedesktop.org
Sat Jul 19 01:34:53 UTC 2014


Module: Mesa
Branch: master
Commit: ecd3e89b32c851f21e8cf2ac78c38e0e12f28ca6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ecd3e89b32c851f21e8cf2ac78c38e0e12f28ca6

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Wed Jul 16 22:19:49 2014 -0700

main/format_pack: Fix a wrong datatype in pack_ubyte_R8G8_UNORM

Before it was only storing one of the color components due to truncation.
With this patch it now properly stores all of them.

Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: "10.2" <mesa-stable at lists.freedesktop.org>

---

 src/mesa/main/format_pack.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/format_pack.c b/src/mesa/main/format_pack.c
index 6b28592..c97c052 100644
--- a/src/mesa/main/format_pack.c
+++ b/src/mesa/main/format_pack.c
@@ -888,7 +888,7 @@ pack_float_R_UNORM8(const GLfloat src[4], void *dst)
 static void
 pack_ubyte_R8G8_UNORM(const GLubyte src[4], void *dst)
 {
-   GLubyte *d = ((GLubyte *) dst);
+   GLushort *d = ((GLushort *) dst);
    *d = PACK_COLOR_88(src[GCOMP], src[RCOMP]);
 }
 




More information about the mesa-commit mailing list