Mesa (master): i965: Silence 'comparison is always true' warning

Ian Romanick idr at kemper.freedesktop.org
Sat Jul 19 22:04:16 UTC 2014


Module: Mesa
Branch: master
Commit: 22b9641edf91f0da76b758db527d4a3b3b2dff82
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=22b9641edf91f0da76b758db527d4a3b3b2dff82

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Wed Jul  2 10:47:54 2014 -0700

i965: Silence 'comparison is always true' warning

The parameter is an int16_t, and we're check that it's value will fit in
16-bits.  Yes, the value that is stored in 16-bits will surely fit in
16-bits.

brw_inst.h: In function 'brw_inst_set_gen6_jump_count':
brw_inst.h:321:66: warning: comparison is always true due to limited range of data type [-Wtype-limits]
brw_inst.h:321:66: warning: comparison is always true due to limited range of data type [-Wtype-limits]

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 src/mesa/drivers/dri/i965/brw_inst.h |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_inst.h b/src/mesa/drivers/dri/i965/brw_inst.h
index 719ac8e..c1ff10d 100644
--- a/src/mesa/drivers/dri/i965/brw_inst.h
+++ b/src/mesa/drivers/dri/i965/brw_inst.h
@@ -306,8 +306,6 @@ static inline void                                                            \
 brw_inst_set_##name(const struct brw_context *brw, brw_inst *inst, int16_t v) \
 {                                                                             \
    assert(assertions);                                                        \
-   assert(v <= (1 << 16) - 1);                                                \
-   assert(v > -(1 << 16));                                                    \
    (void) brw;                                                                \
    brw_inst_set_bits(inst, high, low, (uint16_t) v);                          \
 }                                                                             \




More information about the mesa-commit mailing list