Mesa (master): i965/fs: Fix gl_SampleMask handling for SIMD16 on Gen8+.

Kenneth Graunke kwg at kemper.freedesktop.org
Mon Jul 21 22:02:38 UTC 2014


Module: Mesa
Branch: master
Commit: 29af97f2804442e7952b98f8cea8e8ff740d196e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=29af97f2804442e7952b98f8cea8e8ff740d196e

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Fri Jul 18 13:19:46 2014 -0700

i965/fs: Fix gl_SampleMask handling for SIMD16 on Gen8+.

We actually want to use mov(16), not mov(8).

Fixes 7 Piglit tests: ARB_sample_shading/builtin-gl-sample-mask [2468]
and ARB_sample_shading/builtin-gl-sample-mask-simple [468].

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80991
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Cc: "10.2" <mesa-stable at lists.freedesktop.org>

---

 src/mesa/drivers/dri/i965/gen8_fs_generator.cpp |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
index 2924820..2d745fd 100644
--- a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
+++ b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
@@ -715,13 +715,8 @@ gen8_fs_generator::generate_set_omask(fs_inst *inst,
              mask.hstride == BRW_HORIZONTAL_STRIDE_0);
    }
 
-   unsigned save_exec_size = default_state.exec_size;
-   default_state.exec_size = BRW_EXECUTE_8;
-
    gen8_instruction *mov = MOV(dst, retype(mask, dst.type));
    gen8_set_mask_control(mov, BRW_MASK_DISABLE);
-
-   default_state.exec_size = save_exec_size;
 }
 
 /**




More information about the mesa-commit mailing list