Mesa (master): mesa: mark GL_RGB9_E5 as not color-renderable

Marek Olšák mareko at kemper.freedesktop.org
Sat Mar 15 17:40:06 UTC 2014


Module: Mesa
Branch: master
Commit: 2e361160ffff036fa65f6ca8ee2490b3b193ff3d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e361160ffff036fa65f6ca8ee2490b3b193ff3d

Author: Marek Olšák <marek.olsak at amd.com>
Date:   Sun Mar  9 14:18:45 2014 +0100

mesa: mark GL_RGB9_E5 as not color-renderable

The GL 4.4 spec says it's not color-renderable and not accepted
by RenderBufferStorage. The EXT_texture_shared_exponent spec says
it's not color-renderable but it's accepted by RenderBufferStorageEXT.
This seems to be a bug in the extension spec.

Let's do what GL 4.4 says.

Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/mesa/main/fbobject.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index a9dcc51..dfe2f1e 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -1565,10 +1565,6 @@ _mesa_base_fbo_format(struct gl_context *ctx, GLenum internalFormat)
       return ctx->API == API_OPENGL_COMPAT &&
              ctx->Extensions.ARB_texture_float &&
              ctx->Extensions.ARB_framebuffer_object ? GL_INTENSITY : 0;
-   case GL_RGB9_E5:
-      return (_mesa_is_desktop_gl(ctx)
-              && ctx->Extensions.EXT_texture_shared_exponent)
-         ? GL_RGB : 0;
    case GL_R11F_G11F_B10F:
       return ((_mesa_is_desktop_gl(ctx) && ctx->Extensions.EXT_packed_float) ||
               _mesa_is_gles3(ctx) /* EXT_color_buffer_float */ )




More information about the mesa-commit mailing list