Mesa (master): i965/fs: Delete dead code to fail compiles with SIMD16 pull parameters.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Mar 18 17:36:09 UTC 2014


Module: Mesa
Branch: master
Commit: de77efde91401919fe7282a4b07300a10185792b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=de77efde91401919fe7282a4b07300a10185792b

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Mar 10 23:22:48 2014 -0700

i965/fs: Delete dead code to fail compiles with SIMD16 pull parameters.

The SIMD8 compile will determine whether pull parameters are necessary.
If so, it will set prog_data->nr_pull_params to a value greater than 0.

brw_wm_fs_emit checks if nr_pull_params > 0 and skips the SIMD16 compile
altogether.  So, this code should never occur.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_fs.cpp |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 0945343..c24d2f8 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -1904,11 +1904,6 @@ fs_visitor::setup_pull_constants()
    if (uniforms <= max_uniform_components)
       return;
 
-   if (dispatch_width == 16) {
-      fail("Pull constants not supported in SIMD16\n");
-      return;
-   }
-
    /* Just demote the end of the list.  We could probably do better
     * here, demoting things that are rarely used in the program first.
     */




More information about the mesa-commit mailing list