Mesa (master): vc4: Add a note about a piece of errata I've learned about.

Eric Anholt anholt at kemper.freedesktop.org
Mon Nov 24 20:40:17 UTC 2014


Module: Mesa
Branch: master
Commit: fa74ec7e98edb185806967fb17dd2d885727aa95
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa74ec7e98edb185806967fb17dd2d885727aa95

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Nov 20 19:41:26 2014 -0800

vc4: Add a note about a piece of errata I've learned about.

Right now in my environment I've only got a small CMA area, so this
constraint ends up holding.

---

 src/gallium/drivers/vc4/vc4_draw.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/gallium/drivers/vc4/vc4_draw.c b/src/gallium/drivers/vc4/vc4_draw.c
index e70506b..2d82462 100644
--- a/src/gallium/drivers/vc4/vc4_draw.c
+++ b/src/gallium/drivers/vc4/vc4_draw.c
@@ -48,6 +48,10 @@ vc4_start_draw(struct vc4_context *vc4)
          * BO allocations align to that anyway), then for some reason the
          * simulator wants an extra page available, even if you have overflow
          * memory set up.
+         *
+         * XXX: The binner only does 28-bit addressing math, so the tile alloc
+         * and tile state should be in the same BO and that BO needs to not
+         * cross a 256MB boundary, somehow.
          */
         uint32_t tile_alloc_size = 32 * tilew * tileh;
         tile_alloc_size = align(tile_alloc_size, 4096);




More information about the mesa-commit mailing list