Mesa (master): mesa/program_cache: calloc the correct size for the cache.
Dave Airlie
airlied at kemper.freedesktop.org
Tue Sep 2 06:42:44 UTC 2014
Module: Mesa
Branch: master
Commit: 021e84f292ef4bb26631aec41a31c025ada1e8fd
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=021e84f292ef4bb26631aec41a31c025ada1e8fd
Author: Dave Airlie <airlied at redhat.com>
Date: Tue Sep 2 09:21:18 2014 +1000
mesa/program_cache: calloc the correct size for the cache.
Coverity reported this, and I think this is the right solution,
since cache->items is struct cache_item ** not struct cache_item *,
we also realloc it using struct cache_item * at some point.
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Signed-off-by: Dave Airlie <airlied at redhat.com>
---
src/mesa/program/prog_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/program/prog_cache.c b/src/mesa/program/prog_cache.c
index 07192a9..34609f0 100644
--- a/src/mesa/program/prog_cache.c
+++ b/src/mesa/program/prog_cache.c
@@ -143,7 +143,7 @@ _mesa_new_program_cache(void)
if (cache) {
cache->size = 17;
cache->items =
- calloc(1, cache->size * sizeof(struct cache_item));
+ calloc(cache->size, sizeof(struct cache_item *));
if (!cache->items) {
free(cache);
return NULL;
More information about the mesa-commit
mailing list