Mesa (master): nvc0/ir: uses was always null at that point in the code

Ilia Mirkin imirkin at kemper.freedesktop.org
Tue Sep 9 00:11:12 UTC 2014


Module: Mesa
Branch: master
Commit: 5966903c28a13f13923de308c5f5116a0d5c8cbd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5966903c28a13f13923de308c5f5116a0d5c8cbd

Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Sat Sep  6 12:14:18 2014 -0400

nvc0/ir: uses was always null at that point in the code

Reported by Coverity

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>

---

 src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp
index f13bab1..29857cf 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp
@@ -309,7 +309,6 @@ NVC0LegalizePostRA::insertTextureBarriers(Function *fn)
       }
    }
    delete[] uses;
-   uses = NULL;
 
    // insert the barriers
    for (size_t i = 0; i < useVec.size(); ++i) {
@@ -330,11 +329,8 @@ NVC0LegalizePostRA::insertTextureBarriers(Function *fn)
       }
    }
 
-   if (fn->getProgram()->optLevel < 3) {
-      if (uses)
-         delete[] uses;
+   if (fn->getProgram()->optLevel < 3)
       return true;
-   }
 
    std::vector<Limits> limitT, limitB, limitS; // entry, exit, single
 
@@ -419,8 +415,6 @@ NVC0LegalizePostRA::insertTextureBarriers(Function *fn)
             prev = i;
       }
    }
-   if (uses)
-      delete[] uses;
    return true;
 }
 




More information about the mesa-commit mailing list